pkp/pkp-lib#9658 user access table and table actions

[ipula]

No description provided.

[jardakotesovec]

@withanage @ipula Whats missing is to determine which actions would be available to current user. Here is the logic from original table https://github.com/pkp/pkp-lib/blob/72087f4dabb1e80629b33639e3568501fd309fe2/controllers/grid/settings/user/UserGridRow.php#L84

Most complex likely is LoginAs. For that I would ask Hafsa, whether she could introduce it to the /users endpoint as well, because she worked on the reviewers - pkp/pkp-lib#10290

But meanwhile check whether the other checks (for other actions) would be easy to implement client side or whether there is also some additional complexity, where you don't have enough information client side and it would be necessary to calculate it server side.

[ipula]

@withanage @ipula Whats missing is to determine which actions would be available to current user. Here is the logic from original table https://github.com/pkp/pkp-lib/blob/72087f4dabb1e80629b33639e3568501fd309fe2/controllers/grid/settings/user/UserGridRow.php#L84

Most complex likely is LoginAs. For that I would ask Hafsa, whether she could introduce it to the /users endpoint as well, because she worked on the reviewers - pkp/pkp-lib#10290

But meanwhile check whether the other checks (for other actions) would be easy to implement client side or whether there is also some additional complexity, where you don't have enough information client side and it would be necessary to calculate it server side.

We can check current user id matching with the userId in the actions in vuejs side and hide the actions that not allowed to by the same user.

[ipula]

@jardakotesovec I added the permission check on the loginAs and mergeUser based on pkp/pkp-lib#10658. Please have a look

[jardakotesovec]

This looks great! Basically very minor comments.

Only additional thing I would like to ask you to improve flexibility on extensibility.

Good example is the getItemActions, which will make possible to add some actions from plugin.

Using similar pattern and get list of columns from function so can we make possible to also add column from plugins?
Good example is here https://github.com/pkp/ui-library/blob/main/src/managers/GalleyManager/useGalleyManagerConfiguration.js#L59

[jardakotesovec]

Lets handle this in separate PR. There will be more metadata to add I think anyway.