Attempt to update deps (does not work), see description #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoenixy1
added
help wanted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, I know, I accidentally committed my authtoken for ngrok. I rotated it and the authtoken in this PR is no longer valid.
Anyway, I attempted to update the dependencies (following the checklist here plaid/pattern#317) but after doing so repeatedly hit the client error "cannot use 'in' operator to search for validatestatus" on the client when triggering an ITEM_LOGIN_REQUIRED error.
I am fairly puzzled on this as it seems to be caused by sending a malformed post or delete request via Axios, but the code used by Pattern for sending Axios post requests to the Pattern server appears to be correctly formatted and this error apparently happens regardless of whether I update the Axios version that is used. The regular (transactions-based) pattern app also has exactly the same code for handling ITEM_LOGIN_REQUIRED and does not have this problem after updating dependencies.
Anyway, I spent a few hours on this and then I give up. I am just submitting this in case anyone has any brilliant ideas for fixing the "cannot use 'in' operator to search for validatestatus" error. Please do not spend much time (more than 30-60 minutes) on this; it isn't worth it.