Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker-compose network and use built in docker compose #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix docker-compose network and use built in docker compose #225

wants to merge 1 commit into from

Conversation

skylarmb
Copy link
Contributor

closes #217

@skylarmb skylarmb requested a review from afh June 10, 2021 20:26
skylarmb
skylarmb commented Jun 10, 2021
View reviewed changes
Makefile
@@ -1,4 +1,4 @@
DOCKER_COMPOSE := docker-compose
DOCKER_COMPOSE := docker compose
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose is now built into docker, so this this gets rid of this warning:

Docker Compose is now in the Docker CLI, try `docker compose up`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This change seems to break compatibility with older version of Docker where docker compose is not built-in. Maybe it's something we could provide?

skylarmb
skylarmb commented Jun 10, 2021
View reviewed changes
docker-compose.yml
@@ -74,4 +74,3 @@ services:
ports: ["3000:3000"]
networks:
quickstart:
name: quickstart
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes #217

afh
afh approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile
@@ -1,4 +1,4 @@
DOCKER_COMPOSE := docker-compose
DOCKER_COMPOSE := docker compose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This change seems to break compatibility with older version of Docker where docker compose is not built-in. Maybe it's something we could provide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afh afh afh approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid value "undefined" for header "PLAID-CLIENT-ID"
2 participants
@skylarmb @afh