Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment for maintainability #2513

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Add comment for maintainability #2513

merged 4 commits into from
Jan 3, 2025

Conversation

Akamig
Copy link
Contributor

@Akamig Akamig commented Dec 16, 2024

  • Fixed missing version number change
  • Remove aws-sink-cloudwatch-guid and PlayerUpdateRetryCount related logic
  • Added comments at main process and the entry point of renderer

@Akamig Akamig requested a review from ipdae December 16, 2024 08:48
@Akamig Akamig self-assigned this Dec 16, 2024
Copy link
Member

@ipdae ipdae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단순 주석추가가 아니라 삭제된 코드가 있는데 의도된건가요?

@Akamig
Copy link
Contributor Author

Akamig commented Dec 31, 2024

단순 주석추가가 아니라 삭제된 코드가 있는데 의도된건가요?

어, 삭제된 코드 자체는 인수인계 세션에서 언급되었던 부분이라서 의도된 부분이고요, 코멘트를 다는 대신 삭제하기로 결정한 부분이라고 생각하시면 될것 같습니다.

@Akamig Akamig merged commit 17dae2e into development Jan 3, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants