Feature/synthesize item #3001
Merged
Feature/synthesize item #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
확인했습니다. |
ipdae
requested changes
Nov 25, 2024
|
|
||
| public int GradeId { get; private set; } | ||
| public int RequiredCount { get; private set; } | ||
| public float SucceedRate { get; private set; } |
ipdae
requested changes
Nov 27, 2024
Lib9c/Action/Synthesize.cs
Outdated
| var itemSubType = subTypeItem.Key; | ||
| var materialCount = subTypeItem.Value; | ||
|
|
||
| if (!synthesizeSheet.TryGetValue(gradeId, out var synthesizeRow)) |
There was a problem hiding this comment.
이 gradeId는 루프안에서 변경되는 정보가 아닌것 같습니다. 윗라인으로 옮겨서 호출횟수를 줄일 수 있을것 같습니다.
There was a problem hiding this comment.
아래 커밋에서 수정했습니다
bf33ba9
Lib9c/Action/Synthesize.cs
Outdated
| } | ||
|
|
||
| var randomValue = GetRandomValueForItem(grade, synthesizeResultPool, synthesizeWeightSheet, random, out var itemWeights); | ||
| float cumulativeWeight = 0; |
There was a problem hiding this comment.
float이 아니라 decimal이나 만분율을 써야할 것 같습니다. 성능문제때문에 가급적이면 만분율을 추천합니다.
Lib9c/Action/Synthesize.cs
Outdated
| } | ||
|
|
||
| private float GetRandomValueForItem(Grade grade, HashSet<int> synthesizeResultPool, SynthesizeWeightSheet synthesizeWeightSheet, |
| @@ -30,6 +30,7 @@ public class Synthesize : GameAction | |||
| private const string TypeIdentifier = "synthesize"; | |||
|
|
|||
| private const string MaterialsKey = "m"; | |||
| private const string ChargeApKey = "c"; | |||
There was a problem hiding this comment.
실제 ap충전 동작이 구현안되있는것 같습니다. (ap포션 사용처리)
There was a problem hiding this comment.
아래 커밋에서 구현했습니다. 별도 pr로 뺄까 하다가 구현하기 쉬워보여서 같이 넣자 하고 삽 떠볼려고 필드만 먼저 추가해놨었습니당..
bf33ba9
ipdae
approved these changes
Nov 27, 2024
| // Calculate success for each synthesis | ||
| for (var i = 0; i < synthesizeCount; i++) | ||
| { | ||
| var isSuccess = random.Next(SynthesizeSheet.SucceedRateMax) < synthesizeRow.SucceedRate; |
There was a problem hiding this comment.
<=, < 중에 어떤게 맞는걸까요? 관련 주석을 추가하면 좋을것같습니다.
There was a problem hiding this comment.
아래 pr에서 추가해두었습니다
3274722
|
코드 관련 summary 추가 부탁드립니다. CI가 깨지네요. |
eugene-doobu
merged commit 7f2929e
into
planetarium:feature/growth12
12 of 13 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synthesize item
https://www.notion.so/planetarium/Synthesize-13ded889905f809ebc0def2b45945090