Feature/growth12 #3062
Merged
Feature/growth12 #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduce Synthesize interface
…pool Feature/synthesize result pool
Feature/synthesize item
|
Please rebase/merge 1.20.2 to see only your works. |
Deploying lib9c with
|
| Latest commit: |
531bd83
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ea63e2ca.lib9c.pages.dev |
| Branch Preview URL: | https://feature-growth12.lib9c.pages.dev |
U-lis
reviewed
Dec 3, 2024
Lib9c/TableData/TableExtensions.cs
Outdated
Comment on lines
48
to
59
| public static float ParseFloat(string value) | ||
| { | ||
| if (TryParseFloat(value, out var result)) | ||
| { | ||
| return result; | ||
| } | ||
| throw new ArgumentException(value); | ||
| } | ||
|
|
||
| public static float ParseFloat(string value, float defaultValue) => | ||
| TryParseFloat(value, out var result) ? result : defaultValue; | ||
|
|
There was a problem hiding this comment.
float 를 쓸 일이 없어야 할 것 같은데, ParseFloat 가 어디에서 쓰이나요?
There was a problem hiding this comment.
안쓰이고 있고, 저번주 주간미팅 전 액션에서 float 사용하지 말자고 공지받기 전 추가했던 건데 여기서 바로 제거해두겠습니다
There was a problem hiding this comment.
7c19a07
커밋에서 제거해두었습니다
U-lis
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
250 패치내역과 섞이지 않게 별도 분리했던 브랜치를 병합합니다.