Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/obsolete additem #3108

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Conversation

eugene-doobu
Copy link
Member

@eugene-doobu eugene-doobu commented Dec 27, 2024

ssia

아래 pr내용이 섞여있습니다. 참고 부탁드립니다.
해당 pr의 주 변경사항은 AddItem2를 제거하는 것입니다.

해당 AddItem2는 PAEV가 적용되기 전 액션을 수정하는 과정에서 기존 동작을 보존하기 위해 구현된 것으로 보입니다.
현재 신규 액션에서는 사용되는 코드가 없고, 다른 작업을 진행할때 AddItem2 메서드도 고려해야하나 혼동을 줄 여지가 있어 제거하기로 하였습니다.

#3110

@eugene-doobu eugene-doobu linked an issue Dec 27, 2024 that may be closed by this pull request
@eugene-doobu eugene-doobu requested review from ipdae and U-lis December 27, 2024 08:21
@eugene-doobu eugene-doobu self-assigned this Dec 27, 2024
@eugene-doobu eugene-doobu added this to the v270.0.0 milestone Dec 27, 2024
Copy link
Contributor

@U-lis U-lis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 설명에 AddItem2 가 어떤 것이고, 지금은 어떤걸 사용하기 때문에 지워도 되는지에 대해 설명이 더 있으면 history 파악에 도움이 될 것 같습니다.

Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025

Deploying lib9c with  Cloudflare Pages  Cloudflare Pages

Latest commit: 53c8800
Status: ✅  Deploy successful!
Preview URL: https://d1852c14.lib9c.pages.dev
Branch Preview URL: https://feature-obsolete-additem.lib9c.pages.dev

View logs

@eugene-doobu eugene-doobu merged commit f70fdc5 into development Jan 7, 2025
27 checks passed
@eugene-doobu eugene-doobu deleted the feature/obsolete-additem branch January 7, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Obsolete된 AddItem 관련 코드 제거
3 participants