-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/obsolete additem #3108
Merged
Merged
Feature/obsolete additem #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andom Feature/fix create avatar random
ipdae
approved these changes
Jan 3, 2025
U-lis
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 설명에 AddItem2 가 어떤 것이고, 지금은 어떤걸 사용하기 때문에 지워도 되는지에 대해 설명이 더 있으면 history 파악에 도움이 될 것 같습니다.
Deploying lib9c with
|
Latest commit: |
53c8800
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d1852c14.lib9c.pages.dev |
Branch Preview URL: | https://feature-obsolete-additem.lib9c.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssia
아래 pr내용이 섞여있습니다. 참고 부탁드립니다.
해당 pr의 주 변경사항은 AddItem2를 제거하는 것입니다.
해당 AddItem2는 PAEV가 적용되기 전 액션을 수정하는 과정에서 기존 동작을 보존하기 위해 구현된 것으로 보입니다.
현재 신규 액션에서는 사용되는 코드가 없고, 다른 작업을 진행할때 AddItem2 메서드도 고려해야하나 혼동을 줄 여지가 있어 제거하기로 하였습니다.
#3110