Implement NCIP-25 #3159
Open
Implement NCIP-25 #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ipdae
commented
Feb 10, 2025
•
ipdae
commented
- resolve 월드보스 공헌도 보상 청구 #3158
ipdae
force-pushed
the
feature/issue-3158
branch
2 times, most recently
from
6db0d3e to
dd17a40
Compare
ipdae
force-pushed
the
feature/issue-3158
branch
from
dd17a40 to
2b069c3
Compare
Atralupus
approved these changes
Feb 14, 2025
Deploying lib9c with
|
| Latest commit: |
f981d38
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://762c2da0.lib9c.pages.dev |
| Branch Preview URL: | https://feature-issue-3158.lib9c.pages.dev |
Lib9c/Action/ClaimWorldBossReward.cs
Outdated
| /// </summary> | ||
| [Serializable] | ||
| [ActionType(TypeIdentifier)] | ||
| public class ClaimWorldBossReward : ActionBase |
There was a problem hiding this comment.
base 타입이 GameAction이여야 하는 것 아닐까요?
There was a problem hiding this comment.
클라이언트의 처리때문이라 전달받았고, GameAction으로 변경해두겠습니다.
|
CalculateTicketPrice 관련 기능 변경 추가 필요해보입니다 |
|
|
||
| // Retrieve RaiderState | ||
| var raiderState = new RaiderState((List)states.GetLegacyState(raiderAddress)); | ||
| if (raiderState.HasClaimedReward) |
There was a problem hiding this comment.
클레임했을때 이 값이 변경안된다는거죠? 확인해보겠습니다.
|
@eugene-doobu 티켓가격은 테이블시트에서 조절하는식이라 상태갱신만 반영해뒀습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.