Skip to content

Commit

Permalink
Merge pull request #738 from tyiu/tyiu-718
Browse files Browse the repository at this point in the history
Migrate to Apple-native string catalog and codegen LocalizedStringResources with xcstrings-tool-plugin
  • Loading branch information
martindsq authored Dec 28, 2023
2 parents 8903743 + acbc10b commit 0209599
Show file tree
Hide file tree
Showing 111 changed files with 16,038 additions and 3,370 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Migrate to Apple-native string catalog and codegen LocalizedStringResources with xcstrings-tool-plugin.
- Discover screen can now search notes by id.
- Added pagination to Profile screens.

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ We encourage you to read this guide first or contact any of us. We have a public

## Translations

If you want to contribute by translating the app to another language, you can head in to our [project in Crowdin](https://crowdin.com/project/nossocial) and start translating there. It will automatically generate a Pull Request with your translations that we will happily take care of merging. If we haven't set up the langauge you would like to translate let us know by [opening an issue](https://github.com/planetary-social/nos/issues) or emailing [email protected]. Please do not edit the Generated.strings files in this repository directly.
If you want to contribute by translating the app to another language, you can head in to our [project in Crowdin](https://crowdin.com/project/nossocial) and start translating there. It will automatically generate a Pull Request with your translations that we will happily take care of merging. If we haven't set up the langauge you would like to translate let us know by [opening an issue](https://github.com/planetary-social/nos/issues) or emailing [email protected]. Please do not edit the non-English translations in the .xcstrings files in this repository directly.

## Building

Expand Down
165 changes: 69 additions & 96 deletions Nos.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,15 @@
"version" : "2.14.0"
}
},
{
"identity" : "xcstrings-tool-plugin",
"kind" : "remoteSourceControl",
"location" : "https://github.com/liamnichols/xcstrings-tool-plugin.git",
"state" : {
"revision" : "cc6bd92b9f1a76d380327ea7c555cab9e7867a8c",
"version" : "0.1.1"
}
},
{
"identity" : "xctest-dynamic-overlay",
"kind" : "remoteSourceControl",
Expand Down
4 changes: 0 additions & 4 deletions Nos/Assets/Localization/ExportStrings.sh

This file was deleted.

56 changes: 0 additions & 56 deletions Nos/Assets/Localization/ExportStrings.swift

This file was deleted.

Loading

0 comments on commit 0209599

Please sign in to comment.