Merge pull request #1747 from planetary-social/revert-1744-fix-profil…

…e-appear-loop

Revert "Fix performance issue in ProfileView"

CHANGELOG.md

@@ -19,7 +19,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Added ability to delete lists. [#136](https://github.com/verse-pbc/issues/issues/136)
 - Added analytics for feed source selection and lists. [#129](https://github.com/verse-pbc/issues/issues/129)
 - Fixed: while searching for users to add to a list, NIP-05 searches dismiss the view. [#165](https://github.com/verse-pbc/issues/issues/165)
-- Fixed a performance issue that could occur after switching tabs. [#171](https://github.com/verse-pbc/issues/issues/171)
 - Fixed a crash when processing a malformed delete (kind 5) event. [#170](https://github.com/verse-pbc/issues/issues/170)
 
 ### Internal Changes

Nos/Views/Components/Author/AuthorCard.swift

@@ -15,7 +15,7 @@ enum AvatarOverlayMode {
 /// This view displays the information we have for an author suitable for being used in a list.
 struct AuthorCard<AvatarOverlay: View>: View {
 
-    var author: Author
+    @ObservedObject var author: Author
     @Environment(CurrentUser.self) var currentUser
 
     let avatarOverlayView: () -> AvatarOverlay?

Nos/Views/Components/Author/AuthorLabel.swift

@@ -2,7 +2,7 @@ import SwiftUI
 
 struct AuthorLabel: View {
 
-    var author: Author
+    @ObservedObject var author: Author
     var note: Event?
 
     private var attributedAuthor: AttributedString {

Nos/Views/Components/Author/NIP05View.swift

@@ -4,7 +4,7 @@ import SwiftUI
 
 /// Displays a user's NIP-05 in multiple colors and does some verification on it.
 struct NIP05View: View {
-    var author: Author
+    @ObservedObject var author: Author
 
     @State private var verifiedNip05Identifier: Bool?
     @Dependency(\.namesAPI) private var namesAPI

Nos/Views/Components/BioView.swift

@@ -3,7 +3,7 @@ import SwiftUI
 
 struct BioView: View {
 
-    var author: Author
+    @ObservedObject var author: Author
 
     @Environment(\.managedObjectContext) private var viewContext
 

Nos/Views/Components/Button/CircularButton.swift

@@ -7,7 +7,7 @@ import SwiftUI
 /// Allows the current user to follow or unfollow the author,
 /// and updates its own appearance based on follow state.
 struct CircularFollowButton: View {
-    var author: Author
+    @ObservedObject var author: Author
     @Environment(CurrentUser.self) private var currentUser
     @Dependency(\.analytics) private var analytics
     @Dependency(\.crashReporting) private var crashReporting

Nos/Views/Components/Button/FollowButton.swift

@@ -4,7 +4,7 @@ import CoreData
 
 struct FollowButton: View {
     @ObservedObject var currentUserAuthor: Author
-    var author: Author
+    @ObservedObject var author: Author
     /// A flag used to show a follow or unfollow icon in addition to Follow or
     /// Unfollow text.
     var shouldDisplayIcon = false

Nos/Views/Components/GoldenPostView.swift

@@ -5,7 +5,7 @@ let goldenRatio: CGFloat = 0.618
 
 struct GoldenPostView: View {
 
-    var author: Author
+    @ObservedObject var author: Author
     @ObservedObject var note: Event
 
     @EnvironmentObject private var router: Router

Nos/Views/Components/KnownFollowersView.swift

@@ -5,7 +5,7 @@ import SwiftUI
 /// impersonation attacks by making sure they choose the right person to follow, mention, message, etc. 
 struct KnownFollowersView: View {
 
-    var author: Author
+    @ObservedObject var author: Author
 
     /// The authors that the `source` author follows who also follow the `author`
     @FetchRequest private var knownFollowers: FetchedResults<Author>

Nos/Views/Home/HomeTab.swift

@@ -56,7 +56,7 @@ fileprivate struct PopoverTipView: View {
 }
 
 struct HomeTab: View {
-    var user: Author
+    @ObservedObject var user: Author
 
     @EnvironmentObject private var router: Router
     @ObserveInjection var inject

Nos/Views/Note/NoteCardHeader.swift

@@ -3,7 +3,7 @@ import SwiftUI
 struct NoteCardHeader: View {
 
     @ObservedObject var note: Event
-    var author: Author
+    @ObservedObject var author: Author
 
     var body: some View {
         HStack(alignment: .center, spacing: 8) {

Nos/Views/Profile/ActivityPubBadgeView.swift

@@ -3,7 +3,7 @@ import SwiftUI
 /// A view that displays a badge with an ActivityPub icon.
 struct ActivityPubBadgeView: View {
 
-    var author: Author
+    @ObservedObject var author: Author
 
     var fediverseServer: String {
         let regex = /[0-9A-Za-z._-]+@(?<fediverse>[0-9A-Za-z._-]+)\.mostr\.pub/

Nos/Views/Profile/BioSheet.swift

@@ -3,7 +3,7 @@ import SwiftUI
 
 /// Shows the name, nip-05 and bio of a given user in a vertical stack.
 struct BioSheet: View {
-    var author: Author
+    @ObservedObject var author: Author
 
     @Environment(\.managedObjectContext) private var viewContext
     @Dependency(\.noteParser) private var noteParser

Nos/Views/Profile/Edit/ProfileEditView.swift

@@ -16,7 +16,7 @@ struct ProfileEditView: View {
 
     @Dependency(\.crashReporting) private var crashReporting
 
-    var author: Author
+    @ObservedObject var author: Author
 
     @State private var displayNameText: String = ""
     @State private var bioText: String = ""

Nos/Views/Profile/ProfileHeader.swift

@@ -3,7 +3,7 @@ import CoreData
 import Logger
 
 struct ProfileHeader: View {
-    var author: Author
+    @ObservedObject var author: Author
     @Environment(CurrentUser.self) private var currentUser
 
     @Binding private var selectedTab: ProfileFeedType

Nos/Views/Profile/ProfileTab.swift

@@ -5,7 +5,7 @@ import SwiftUI
 struct ProfileTab: View {
 
     @Environment(CurrentUser.self) var currentUser
-    var author: Author
+    @ObservedObject var author: Author
 
     @Binding var path: NavigationPath
 

Nos/Views/Profile/ProfileView.swift

@@ -6,7 +6,7 @@ import Logger
 
 struct ProfileView: View {
 
-    var author: Author
+    @ObservedObject var author: Author
     var addDoubleTapToPop = false
 
     @Environment(\.managedObjectContext) private var viewContext

Nos/Views/Relay/RelayView.swift

@@ -12,7 +12,7 @@ struct RelayView: View {
     @Environment(\.managedObjectContext) private var viewContext
     @Environment(RelayService.self) private var relayService
     @Environment(CurrentUser.self) private var currentUser
-    var author: Author
+    @ObservedObject var author: Author
 
     @State var newRelayAddress: String = ""