Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes toggle white background color bug #1484

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Fixes toggle white background color bug #1484

merged 10 commits into from
Sep 11, 2024

Conversation

pelumy
Copy link
Contributor

@pelumy pelumy commented Sep 10, 2024

Issues covered

#1251

Description

This PR fixes the issue with the toggles' background color being changed to white instead of green, after it has been turned on. The following changes were made:

  • A new component NosToggle with a tint color of green to override the white tint color set in the AppView; is added to the project.
  • The Toggles in the SettingsView are replaced with the new NosToggle component.

How to test

  1. Build the app.
  2. Click the side menu at the top left of the app.
  3. Click the settings menu
  4. Please scroll through the page and see that the toggles' background colors are green when turned on.

Screenshots/Video

Before After
Before After

@joshuatbrown joshuatbrown self-assigned this Sep 10, 2024
joshuatbrown
joshuatbrown reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@joshuatbrown joshuatbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly and wow is it nice to have this bug fixed! Would you mind replacing the one last Toggle in ComposerActionBar with this excellent NosToggle?

CHANGELOG.md Outdated Show resolved Hide resolved
Nos/Views/Components/NosToggle.swift Show resolved Hide resolved
@pelumy
Copy link
Contributor Author

pelumy commented Sep 10, 2024

Works perfectly and wow is it nice to have this bug fixed! Would you mind replacing the one last Toggle in ComposerActionBar with this excellent NosToggle?

Oops, that looked like a Toggle added to previews to me. I will make the change

@pelumy pelumy changed the title bugFix/toggle-background-color Fixes toggle white background color bug Sep 10, 2024
@pelumy pelumy requested a review from joshuatbrown September 11, 2024 10:13
joshuatbrown
joshuatbrown approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@joshuatbrown joshuatbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for the updates!

@pelumy pelumy enabled auto-merge September 11, 2024 15:10
@pelumy pelumy added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 1ae8c74 Sep 11, 2024
4 checks passed
@pelumy pelumy deleted the bugFix/toggle-bg-color branch September 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuatbrown joshuatbrown joshuatbrown approved these changes

@mplorentz mplorentz Awaiting requested review from mplorentz mplorentz is a code owner

@martindsq martindsq Awaiting requested review from martindsq martindsq is a code owner

Assignees

@joshuatbrown joshuatbrown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pelumy @joshuatbrown @mplorentz