refactor push notification registration and fix re-registration issue #1501 #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmontz
requested review from
mplorentz,
martindsq and
joshuatbrown
as code owners
joshuatbrown
approved these changes
Sep 17, 2024
# Conflicts: # CHANGELOG.md # Nos.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#1501
Description
Addresses an issue where push notifications are not re-registered for after the initial registration in a session when the user signs out and then into another account.
I ended up doing a refactor of how this is done to make the registration more isolated, encapsulated, and maintainable.
How to test
Prior to the changes in this PR, you will not receive push notifications associated with the newly signed-in account. After the changes, you will.
Screenshots/Video
Before:
You can see in the video below that when you launch the app signed in to an account, then sign out, then sign in to a different account, the user/device is not re-registered for push notifications.
before.mp4
After:
In the after video below, you can see that the user is registered for notifications on launch, then when the user signs out and then into another account, the new account is registered for push notifications.
after.mp4