Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: tapping a user on a list causes a crash #172 #1746

Merged
merged 2 commits into from
Jan 31, 2025
Merged

fixed: tapping a user on a list causes a crash #172 #1746

merged 2 commits into from
Jan 31, 2025

Conversation

bryanmontz
Copy link
Contributor

Issues covered

https://github.com/verse-pbc/issues/issues/172

Description

Fixes an issue where the app would crash when you tap a user on a list view.

This happened because I originally chose to use NavigationLink rather than Router to push views. Moving to Router fixed it.

How to test

  1. Navigate to the Manage Lists screen
  2. Tap a list to view its detail view
  3. Tap a profile

Screenshots/Video

Before After
broken fixed

@bryanmontz bryanmontz self-assigned this Jan 31, 2025
@mplorentz
Copy link
Member

👀

@mplorentz mplorentz requested a review from martindsq as a code owner January 31, 2025 18:56
mplorentz
mplorentz approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mplorentz mplorentz enabled auto-merge January 31, 2025 19:00
@mplorentz mplorentz added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 3b55128 Jan 31, 2025
4 checks passed
@mplorentz mplorentz deleted the bdm/172-list-profile-push branch January 31, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mplorentz mplorentz mplorentz approved these changes

@joshuatbrown joshuatbrown Awaiting requested review from joshuatbrown joshuatbrown is a code owner

@pelumy pelumy Awaiting requested review from pelumy pelumy is a code owner

@martindsq martindsq Awaiting requested review from martindsq martindsq is a code owner

Assignees

@bryanmontz bryanmontz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanmontz @mplorentz