Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind 20 support for picture notes posted from Olas #1753

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

rabble
Copy link
Contributor

@rabble rabble commented Feb 4, 2025

Issues covered

Add support for picture notes in feeds

Description

This PR adds support for displaying picture notes (posts containing images) in the feed with an optimized layout. Key changes include:

  • Added new PictureNoteCard view component for image-focused note display
  • Updated feed views to detect and use picture-specific layout when appropriate
  • Added image loading and caching support
  • Handles both single and multiple image scenarios
  • Maintains consistent styling with existing note cards

How to test

  1. Launch app and navigate to main feed
  2. Look for posts containing images - they should now show the image prominently
  3. Test posting a new note with an image attachment
  4. Verify images load properly in both light and dark mode
  5. Check that tapping images opens them in full screen viewer
  6. Verify multiple image handling works as expected

Screenshots/Video

Updated UI
Screenshot 2025-02-04 at 1 59 47 PM

Screenshot 2025-02-04 at 2 00 35 PM

Old version not displaying kind 20 events.
Screenshot 2025-02-04 at 2 01 04 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant