SchemaBuilder Per Connection Grammar #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… newer Framework changes.
m-triassi
approved these changes
Oct 9, 2024
| use Plank\Snapshots\Schema\SQLiteSnapshotBuilder; | ||
| use Plank\Snapshots\Schema\SqlServerSnapshotBuilder; | ||
|
|
||
| describe('The Schema Builder is resolved in the container based on the db connection', function () { |
There was a problem hiding this comment.
Not something we need to tackle in this PR: It might be interesting to eventually have the test suites actually run on each schema builder, and see if they behave as expected.
This is a great first step towards that imho, just making sure the system can resolve correct builder is excellent.
There was a problem hiding this comment.
Would definitely be nice assurance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Laravel Framework added some new methods (ie:
getIndexes(),getColumns()) to the Schema Builder, and in order to do so, they needed to break out the Schema Builder implementations per Database Connection Grammar.As a result, we also need to provide a Grammar specific set of
SnapshotSchemaBuilders in order to expose the new methods add in Laravel.This should be a non breaking change, as the service container bindings should still resolve to the old base builder if the new framework builder classes aren't there.
Tests