-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing entries. #10
Conversation
Hello @Potherca, I see the changes in Have you just re-run the groovy script to regenerate the list? Or have you fixed something in groovy script which is missing in this MR? Regards |
I cheated and created the list in bash, from the |
Hello, I think you did a good job fixing the listing, but I would avoid leaving something inconsistent (not documented or automated approach), otherwise, we may not remember in the future how we got the listing "working", if we ever want to revisit our steps or want to release a new version. I have created this branch where I have updated to use groovy 4 and latest dependencies, and most of the listing is complete. There are some missing entries because the logos are no longer in gilbarbara/logos repo or have changed names. If you want, after review, you, or me, can just merge it into master. I think we should add to the script to remove them from this repo when that happens (is just adding logic to clean pngs and pumls folders at script initialization). That would imply that if some user doesn't use a tag, and use master, then diagrams using such logos may stop "working", but in general I think users should just use tagged versions. What do you think? |
Fair enough. 👍
We could leave the removed logos in (to avoid backward incompatibility). That would require other logic. It would make it possible to mark logos that have been removed/renamed upstream in the markdown file. Also, maybe there is a way of marking things as deprecated, instead of directly removing them. Not sure.
The issue here is when users don't include this project using a URL (with a version) but through PlantUML directy (with the It such cases, removing things will cause unexpected breakage for users. It is possible adding "versioning" by using folders which include a version number (like |
I have added to the branch logic to mark deprecated sprites. Let me know if it looks good to you, mainly checking generated listing. If so, you (or me) can merge the changes and tag the release. |
Closing this in favor of fixing things in the script as suggested by @rabelenda.
You are very welcome! Glad to see combining our efforts into one |
As discovered during #7, some
.pngs
that have a*.puml
counterparts are not listed insprites-list.md
.This MR fixes that, so we can release
v1.1.0
, and take our time in fixing the root problem.