Update to TLJH 1.0 #224
Draft
Update to TLJH 1.0 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking to the related PR in |
Open
jtpio
commented
Nov 28, 2023
| jupyterhub~=1.5 | ||
| notebook<7 | ||
| git+https://github.com/jupyterhub/[email protected] | ||
| git+https://github.com/jtpio/tljh-repo2docker@jupyterhub-4 |
There was a problem hiding this comment.
This can be updated when there is a proper tag on https://github.com/plasmabio/tljh-repo2docker that includes the changes from plasmabio/tljh-repo2docker#65.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216
Trying to test #217 on a VM was leading to issues installing the Python requirements from the custom branch. However using the default installer together with #217 seems to be working well.
For reference we were still pointing to a branch of my TLJH fork which had a floag to not create a base user environment since Plasma uses Docker: jupyterhub/the-littlest-jupyterhub#528
However this upstream PR has been closed and there is no ongoing work to re-add a similar feature at the moment.
That said this PR was initially raised because creating the default environment used to be taking a very long time when it was still installing JupyterLab 2 and building it with extensions. Now TLJH has switch to JupyterLab 3+ and mamba, and creating the default environment is much faster now.