Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Support for non-default Postgres Schema #85

Merged
merged 3 commits into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 12 additions & 26 deletions migrations/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
from dotenv import load_dotenv
from sqlalchemy import engine_from_config, pool, text

# Import your models
from src.db import Base

# Set up logging more verbosely
logging.basicConfig()
logging.getLogger("sqlalchemy.engine").setLevel(logging.INFO)
logging.getLogger("alembic").setLevel(logging.DEBUG)

# Import your models
from src.db import Base

# Add project root to Python path
sys.path.append(str(Path(__file__).parents[1]))

Expand Down Expand Up @@ -43,13 +43,6 @@
# ... etc.


def include_name(name, type_, parent_names):
if type_ == "schema":
return name == target_metadata.schema
else:
return True


def get_url() -> str:
url = os.getenv("CONNECTION_URI")
if url is None:
Expand All @@ -71,20 +64,15 @@ def run_migrations_offline() -> None:
"""
url = get_url()

print(target_metadata.schema)

context.configure(
url=url,
target_metadata=target_metadata,
literal_binds=True,
dialect_opts={"paramstyle": "named"},
version_table_schema=target_metadata.schema, # This sets schema for version table
include_schemas=True,
include_name=include_name,
)

with context.begin_transaction():
context.execute(f"create schema if not exists {target_metadata.schema};")
context.execute(f"SET search_path TO {target_metadata.schema}")
context.run_migrations()

Expand All @@ -96,15 +84,14 @@ def run_migrations_online() -> None:
and associate a connection with the context.

"""

configuration = config.get_section(config.config_ini_section)
if configuration is None:
configuration = {}

url = get_url()
configuration["sqlalchemy.url"] = url

print(f"Debug - Target metadata schema: {target_metadata.schema}")

connectable = engine_from_config(
configuration,
prefix="sqlalchemy.",
Expand All @@ -113,26 +100,25 @@ def run_migrations_online() -> None:
)

with connectable.connect() as connection:
# Create schema and commit it outside the main migration transaction
connection.execute(
text(f"CREATE SCHEMA IF NOT EXISTS {target_metadata.schema};")
)
connection.execute(
text(f"GRANT ALL ON SCHEMA {target_metadata.schema} TO current_user")
)
# Set and verify search_path
connection.execute(text(f"SET search_path TO {target_metadata.schema}, public"))

# make use of non-supported SQLAlchemy attribute to ensure
# the dialect reflects tables in terms of the current tenant name
# connection.dialect.default_schema_name = target_metadata.schema
connection.commit()

context.configure(
connection=connection,
target_metadata=target_metadata,
version_table_schema=target_metadata.schema,
include_schemas=True,
include_name=include_name,
transaction_per_migration=True,
transactional_ddl=True,
)

with context.begin_transaction():
context.run_migrations()
connection.commit()


if context.is_offline_mode():
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

def upgrade() -> None:
schema = getenv("DATABASE_SCHEMA", "public")

# Add new indexes
op.create_index(
"idx_users_app_lookup", "users", ["app_id", "public_id"], schema=schema
Expand Down
Loading