Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ben/dev 93 #199

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Ben/dev 93 #199

wants to merge 5 commits into from

Conversation

bLopata
Copy link
Contributor

@bLopata bLopata commented Jan 2, 2025 •
edited
Loading

Refactors to Chat.tsx and a couple of other components to reduce re-renders from million.dev code review.

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tutor-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 4:10pm

@bLopata bLopata marked this pull request as ready for review January 2, 2025 19:03
@bLopata bLopata requested a review from VVoruganti January 2, 2025 19:03
@VVoruganti
Copy link
Collaborator

General conventions say to be more conservative with how often you use functions like useCallback or useMemo need to do some local testing to see how the app feels with the changes. Another thing to consider is also using the million react compiler to automatically improve speed:

https://old.million.dev/docs/introduction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VVoruganti VVoruganti Awaiting requested review from VVoruganti

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bLopata @VVoruganti