Adds `export` functionality to chat, removes poetry in favor of uv, bumps Honcho version to `v0.0.14/python-SDK-0.0.19` #15

bLopata · 2025-01-07T19:01:53Z

Solves dev-552, dev-494, dev-561

cloudflare-workers-and-pages · 2025-01-07T21:57:24Z

Deploying yousim with Cloudflare Pages

Latest commit:	`9756163`
Status:	✅ Deploy successful!
Preview URL:	https://479d6067.yousim.pages.dev
Branch Preview URL:	https://ben-dev-552.yousim.pages.dev

View logs

hyusap · 2025-01-07T23:43:42Z

app.py

+        ]
+
+        # Create a temporary file
+        with tempfile.NamedTemporaryFile(mode='w', delete=False, suffix='.json') as tmp:


is writing to disk necessary here? i feel like this could be done in memeory

or is this already in memory? i've never used this library before, if so, neat trick.

From python docs
tempfile.TemporaryFile(mode='w+b', buffering=-1, encoding=None, newline=None, suffix=None, prefix=None, dir=None, *, errors=None) Return a [file-like object](https://docs.python.org/3/glossary.html#term-file-like-object) that can be used as a temporary storage area. The file is created securely, using the same rules as [mkstemp()](https://docs.python.org/3/library/tempfile.html#tempfile.mkstemp). It will be destroyed as soon as it is closed (including an implicit close when the object is garbage collected). Under Unix, the directory entry for the file is either not created at all or is removed immediately after the file is created. Other platforms do not support this; your code should not rely on a temporary file created using this function having or not having a visible name in the file system.

Output from claude about it. Maybe we should used SpooledTemporaryFile

The Python tempfile library provides both in-memory and on-disk temporary storage options. Let me explain the key functionality:

For on-disk temporary files and directories:

tempfile.NamedTemporaryFile(): Creates a temporary file on disk with an actual file name in the filesystem. By default, it's automatically deleted when closed.

tempfile.mkstemp(): Creates a temporary file on disk and returns both a file descriptor and the file path. Doesn't automatically delete the file.

tempfile.mkdtemp(): Creates a temporary directory on disk and returns its path.

For in-memory temporary storage:

tempfile.SpooledTemporaryFile(): Creates a file-like object that initially stores data in memory. If the data exceeds a size threshold (default 0.5MB), it automatically switches to using disk storage.

Here's a practical example:

import tempfile # On-disk temporary file with tempfile.NamedTemporaryFile() as tf: tf.write(b"Some data") tf.seek(0) print(tf.read()) # File is automatically deleted after this block # In-memory with potential disk spillover with tempfile.SpooledTemporaryFile(max_size=1024) as tf: tf.write(b"In memory until exceeding 1KB") tf.seek(0) print(tf.read())

The temporary files are created in your system's default temporary directory (usually /tmp on Unix-like systems or the user's temp directory on Windows). This location can be customized using the dir parameter in these functions.

Would you like me to explain any specific aspect in more detail?

hyusap · 2025-01-07T23:45:25Z

docker-compose.yml


 services:
  backend:
    build:
      context: .
      dockerfile: Dockerfile
    ports:
-      - "8000:8000"
+      - "${PORT}:${PORT}"


why do we care about the port within the container?

I made this more complicated than needed because I was running my honcho fastAPI on (the default) port 8000, so I was specifying here to avoid any problems. I will fix this.

Should just stick to default setup in the compose. Can change as we need in local development, but shouldn't push it up.

hyusap · 2025-01-07T23:47:23Z

pyproject.toml

@@ -1,23 +1,25 @@
-[tool.poetry]


good riddance haha, uv supremacy

webshell/Dockerfile

hyusap · 2025-01-07T23:50:36Z

webshell/Dockerfile

-RUN npm run build
-
-# Expose the port the app runs on
+# Use development server


should we use a dev server in this case?

The docker container is really used for development. In production we are just serving the static front end. the dev server is really just to make it easy to serve locally

…nges export from tempfile to in memory.

VVoruganti · 2025-01-08T15:44:22Z

Dockerfile

+# Copy requirements and install dependencies
+COPY requirements.txt .
+RUN uv pip install --system -r requirements.txt


Should probably be a uv sync command. Should follow conventions from honcho repo or on https://docs.astral.sh/uv/guides/integration/docker/

VVoruganti · 2025-01-08T15:44:53Z

Dockerfile

-
-# https://stackoverflow.com/questions/29663459/python-app-does-not-print-anything-when-running-detached-in-docker
-CMD ["fastapi", "run", "app.py", "--host", "0.0.0.0", "--port", "8000"]
+EXPOSE ${PORT}


internal port doesn't matter we can always change what port we expose on the outside. should just keep this to static port

VVoruganti · 2025-01-08T15:58:36Z

app.py

+    try:
+        session = honcho.apps.users.sessions.create(
+            app_id=honcho_app.id, 
+            user_id=user_id,
+        )
+    except TypeError as e:
+        if "location_id" in str(e):
+            # If location_id is truly optional, try without it
+            session = honcho.apps.users.sessions.create(
+                app_id=honcho_app.id,
+                user_id=user_id
+            )
+        else:
+            raise e
+


Is this for backwards compatability?

VVoruganti · 2025-01-08T16:00:57Z

app.py

+        ]
+
+        # Create a temporary file
+        with tempfile.NamedTemporaryFile(mode='w', delete=False, suffix='.json') as tmp:


Output from claude about it. Maybe we should used SpooledTemporaryFile

The Python tempfile library provides both in-memory and on-disk temporary storage options. Let me explain the key functionality:

For on-disk temporary files and directories:

tempfile.NamedTemporaryFile(): Creates a temporary file on disk with an actual file name in the filesystem. By default, it's automatically deleted when closed.

tempfile.mkstemp(): Creates a temporary file on disk and returns both a file descriptor and the file path. Doesn't automatically delete the file.

tempfile.mkdtemp(): Creates a temporary directory on disk and returns its path.

For in-memory temporary storage:

tempfile.SpooledTemporaryFile(): Creates a file-like object that initially stores data in memory. If the data exceeds a size threshold (default 0.5MB), it automatically switches to using disk storage.

Here's a practical example:

import tempfile # On-disk temporary file with tempfile.NamedTemporaryFile() as tf: tf.write(b"Some data") tf.seek(0) print(tf.read()) # File is automatically deleted after this block # In-memory with potential disk spillover with tempfile.SpooledTemporaryFile(max_size=1024) as tf: tf.write(b"In memory until exceeding 1KB") tf.seek(0) print(tf.read())

The temporary files are created in your system's default temporary directory (usually /tmp on Unix-like systems or the user's temp directory on Windows). This location can be customized using the dir parameter in these functions.

Would you like me to explain any specific aspect in more detail?

VVoruganti · 2025-01-08T16:02:17Z

pyproject.toml

+    {name = "vintro", email = "[email protected]"},
+    {name = "vineeth", email = "[email protected]"}


Can just change this to {name = "Plastic Labs", email = "[email protected]"}, Everyone played a part.

VVoruganti · 2025-01-08T16:03:56Z

webshell/src/honcho.ts

+      const contentDisposition = response.headers.get('content-disposition');
+      const filename = contentDisposition
+        ? contentDisposition.split('filename=')[1].replace(/['"]/g, '')
+        : 'yousim_conversation.json';


Should we name the file based on the name of the simulation?

VVoruganti · 2025-01-14T16:01:46Z

app.py

+        sessions_page = honcho.apps.users.sessions.list(
+            app_id=honcho_app.id,
+            user_id=user_id
+        )
+        sessions = list(sessions_page)


Can get a session directly with a get method

VVoruganti · 2025-01-14T16:02:49Z

app.py

+        for session in sessions:
+            if str(session.id) == session_id:
+                return str(session.id)
+
+        print("No session found with matching ID, checking legacy metadata...")
+        # If not found, check legacy metadata
+        for session in sessions:
+            if session.metadata and session.metadata.get("legacy_id") == session_id:
+                print(f"Found matching legacy session! ID: {session.id}")
+                return str(session.id)


Can do a list method and pass in a filter object to filter by legacy_id

VVoruganti · 2025-01-14T16:04:38Z

app.py

+            sessions = honcho.apps.users.sessions.list(
+                app_id=honcho_app.id,
+                user_id=current_user_id
+            )
+
+            for session in sessions:
+                if session.metadata and session.metadata.get("legacy_id") == session_id:
+                    return await get_session_messages(session_id=str(session.id), user_id=current_user_id)


Again can filter directly on the list call

bLopata added 2 commits January 7, 2025 13:01

Adds export functionality to chat, removes poetry in favor of uv.

b908a3b

Bump honcho version.

f990741

Bump honcho version in toml file.

1104be1

bLopata changed the title ~~Adds export functionality to chat, removes poetry in favor of uv.~~ Adds export functionality to chat, removes poetry in favor of uv, bumps Honcho version to v0.0.14/python-SDK-0.0.19 Jan 7, 2025

bLopata requested review from VVoruganti and hyusap January 7, 2025 22:15

bLopata marked this pull request as ready for review January 7, 2025 22:16

hyusap reviewed Jan 7, 2025

View reviewed changes

bLopata added 2 commits January 8, 2025 01:10

Update webshell/Dockerfile

b678112

Adds backwards compatability for existing share links with UUIDS, cha…

9756163

…nges export from tempfile to in memory.

VVoruganti requested changes Jan 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds `export` functionality to chat, removes poetry in favor of uv, bumps Honcho version to `v0.0.14/python-SDK-0.0.19` #15

Adds `export` functionality to chat, removes poetry in favor of uv, bumps Honcho version to `v0.0.14/python-SDK-0.0.19` #15

bLopata commented Jan 7, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 7, 2025 •

edited

Loading

hyusap Jan 7, 2025

hyusap Jan 7, 2025

bLopata Jan 8, 2025 •

edited

Loading

VVoruganti Jan 8, 2025

hyusap Jan 7, 2025

bLopata Jan 8, 2025

VVoruganti Jan 14, 2025

hyusap Jan 7, 2025

hyusap Jan 7, 2025

VVoruganti Jan 8, 2025

VVoruganti Jan 8, 2025

VVoruganti Jan 8, 2025

VVoruganti Jan 8, 2025

VVoruganti Jan 8, 2025

VVoruganti Jan 8, 2025 •

edited

Loading

VVoruganti Jan 8, 2025

VVoruganti Jan 14, 2025

VVoruganti Jan 14, 2025

VVoruganti Jan 14, 2025

		{name = "vintro", email = "[email protected]"},
		{name = "vineeth", email = "[email protected]"}

Adds export functionality to chat, removes poetry in favor of uv, bumps Honcho version to v0.0.14/python-SDK-0.0.19 #15

Are you sure you want to change the base?

Adds export functionality to chat, removes poetry in favor of uv, bumps Honcho version to v0.0.14/python-SDK-0.0.19 #15

Conversation

bLopata commented Jan 7, 2025 • edited Loading

cloudflare-workers-and-pages bot commented Jan 7, 2025 • edited Loading

Deploying yousim with Cloudflare Pages

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bLopata Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Would you like me to explain any specific aspect in more detail?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Would you like me to explain any specific aspect in more detail?

VVoruganti Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Adds `export` functionality to chat, removes poetry in favor of uv, bumps Honcho version to `v0.0.14/python-SDK-0.0.19` #15

Adds `export` functionality to chat, removes poetry in favor of uv, bumps Honcho version to `v0.0.14/python-SDK-0.0.19` #15

bLopata commented Jan 7, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 7, 2025 •

edited

Loading

bLopata Jan 8, 2025 •

edited

Loading

VVoruganti Jan 8, 2025 •

edited

Loading