Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace groovy.json.JsonOutput with kotlinx.serialization.json in JsonReporter #74 #76

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

jglaszka
Copy link
Collaborator

related to #74

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #76 (2bb14e4) into main (cb0c657) will increase coverage by 8.85%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   50.74%   59.60%   +8.85%     
==========================================
  Files          19       19              
  Lines         201      203       +2     
  Branches       18       18              
==========================================
+ Hits          102      121      +19     
+ Misses         96       79      -17     
  Partials        3        3              
Files Coverage Δ
...sts_execution_chart/reporters/json/JsonReporter.kt 85.71% <100.00%> (+85.71%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@3750 3750 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice. Small suggestions regarding test.

@platan platan merged commit 61c0324 into main Oct 18, 2023
7 checks passed
@platan
Copy link
Owner

platan commented Oct 18, 2023

@jglaszka thank you for your contribution.

@platan platan deleted the feature/clean-groovy-from-main-package branch October 28, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants