Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kotlinx cli #77

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Replace kotlinx cli #77

merged 2 commits into from
Oct 18, 2023

Conversation

KKolej
Copy link

@KKolej KKolej commented Oct 18, 2023

replace

    functionalTestImplementation("org.jetbrains.kotlinx:kotlinx-cli:0.3.6")

to

    functionalTestImplementation("com.github.ajalt.clikt:clikt:4.2.1")

result ``` ./gradlew createRegressionHtmlReport ````
Before:
Before
After:
After

@3750
Copy link

3750 commented Oct 18, 2023

This PR fixes #73

@platan
Copy link
Owner

platan commented Oct 18, 2023

Before

# no args
Value for option --input should be always provided in command line.
Usage: jsonToHtml options_list
Options: 
    --input -> Input file in JSON format (always required) { String }
    --output-dir (always required) { String }
    --mermaid-script-src [https://cdn.jsdelivr.net/npm/[email protected]/dist/mermaid.min.js] { String }
    --embed-mermaid-script [false] 
    --mermaid-max-text-size [50000] { Int }
    --task-name [test] { String }
    --help, -h -> Usage info 


Process finished with exit code 127

# --help arg

Usage: jsonToHtml options_list
Options: 
    --input -> Input file in JSON format (always required) { String }
    --output-dir (always required) { String }
    --mermaid-script-src [https://cdn.jsdelivr.net/npm/[email protected]/dist/mermaid.min.js] { String }
    --embed-mermaid-script [false] 
    --mermaid-max-text-size [50000] { Int }
    --task-name [test] { String }
    --help, -h -> Usage info 


Process finished with exit code 0

After:

# no args
Usage: command-line-parser [<options>]

Error: missing option --input
Error: missing option --output-dir

Process finished with exit code 1

# with --help arg
Usage: command-line-parser [<options>]

Options:
  --input=<text>               Input file in JSON format
  --output-dir=<text>
  --mermaid-script-src=<text>
  --embed=true|false
  --max-text-size=<int>
  --task-name=<text>
  -h, --help                   Show this message and exit

Process finished with exit code 0

@platan platan merged commit cb0c657 into platan:main Oct 18, 2023
2 checks passed
@platan
Copy link
Owner

platan commented Oct 18, 2023

@KKolej thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants