Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependentMaxes rate limiting config #10

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

flakey5
Copy link
Collaborator

@flakey5 flakey5 commented Mar 26, 2024

Provides a simple way to associate JWT claims with different rate limits

@flakey5 flakey5 requested a review from mcollina March 26, 2024 20:30
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are needed


Can you also send an example to fastify-rate-limiting with this approach? A doc/example would be good.

lib/schema.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
@flakey5 flakey5 force-pushed the flakey5/rate-limiting branch 2 times, most recently from 18bdd84 to 965a1b3 Compare April 8, 2024 22:26
@flakey5 flakey5 marked this pull request as ready for review April 8, 2024 22:26
@flakey5 flakey5 force-pushed the flakey5/rate-limiting branch from 965a1b3 to 8d48cc1 Compare April 10, 2024 00:48
@mcollina
Copy link
Member

CI is failing

@flakey5 flakey5 force-pushed the flakey5/rate-limiting branch from 8d48cc1 to 02783cb Compare April 11, 2024 03:30
Provides a simple way to associate JWT claims with different rate limits
@flakey5 flakey5 force-pushed the flakey5/rate-limiting branch from 02783cb to d2729f5 Compare April 11, 2024 03:32
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flakey5 flakey5 merged commit 9ad3c06 into main Apr 11, 2024
4 checks passed
@flakey5 flakey5 deleted the flakey5/rate-limiting branch April 11, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants