Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup provider constructors #18

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

flakey5
Copy link
Collaborator

@flakey5 flakey5 commented Apr 14, 2024

Makes constructors for the different ai providers take in objects instead of a bunch of properties so it's clearer when initializing

Makes constructors for the different ai providers take in objects instead of a bunch of properties so it's clearer when initializing
@flakey5 flakey5 force-pushed the flakey5/cleanup-provider-constructors branch from 14f83bf to 0688ccd Compare April 14, 2024 01:13
@flakey5 flakey5 requested a review from mcollina April 14, 2024 01:14
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5114fcf into main Apr 14, 2024
5 checks passed
@flakey5 flakey5 deleted the flakey5/cleanup-provider-constructors branch April 14, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants