Make build output esm #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow us to cleanup some of the logic for the AI providers (including most of the `// @ts-expect-error` comments) and allows us to mock imports (which we'll be using for llama2 support).
flakey5
force-pushed
the
flakey5/use-esm
branch
from
957b789 to
48b397d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow us to cleanup some of the logic for the AI providers (including most of the
// @ts-expect-errorcomments) and allows us to mock imports (which we'll be using for llama2 support).Unfortunately, with
moduleandmoduleResolutionset toNodeNextin the tsconfig, we need to add .js extensions to relative imports. If we setmoduleandmoduleResolutiontoESNext, this removes that requirement at build time. At runtime it will throw module not found errors because of the missing file extension. I haven't been able to find anything in the tsconfig that will add the file extensions for us either, and the next best solution would be to have some additional build step that goes into each file and adds the file extension. Regardless, it should be doable but I'm leaning towards this approach being better (although a bit ugly).