Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add designed front end #32

Merged
merged 3 commits into from
May 9, 2024
Merged

Add designed front end #32

merged 3 commits into from
May 9, 2024

Conversation

flakey5
Copy link
Collaborator

@flakey5 flakey5 commented May 7, 2024 •
edited
Loading

TODO:

  • Add search arrow button for the prompt input
  • Fonts
  • Side glow effects for the main diagram
  • Fill in placeholder text
  • General cleanup
  • Double check exact padding & margins
  • Popups
  • Response regeneration
  • Response editing
  • Response copying

@flakey5
Copy link
Collaborator Author

flakey5 commented May 7, 2024 •
edited
Loading

chat.html will be in the next pr - for now I just moved the old index page there

@flakey5 flakey5 force-pushed the flakey5/frontend branch from 94ab18b to f4ed9fe Compare May 7, 2024 20:10
@flakey5 flakey5 marked this pull request as ready for review May 7, 2024 20:42
@mcollina
Copy link
Member

mcollina commented May 8, 2024 •
edited by flakey5
Loading

  • Pressing enter should trigger the prompt
  • currently clicking the button loads the chat.html page
  • Add a few prompt examples

I don't think you pushed the content in the latest video.

@flakey5 flakey5 force-pushed the flakey5/frontend branch from f4ed9fe to 22d1e90 Compare May 8, 2024 15:54
@flakey5 flakey5 changed the title Add designed index page Add designed front end May 8, 2024
@flakey5 flakey5 force-pushed the flakey5/frontend branch from 22d1e90 to c6b3298 Compare May 8, 2024 20:21
@flakey5 flakey5 linked an issue May 8, 2024 that may be closed by this pull request
Create Simple “default” UI for querying the LLMs. #23
Closed
@flakey5 flakey5 force-pushed the flakey5/frontend branch from c6b3298 to 0472cb2 Compare May 9, 2024 07:48
@mcollina
fix some stuff for llama2 compat
f6ba320 
Signed-off-by: Matteo Collina <[email protected]>
mcollina
mcollina approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I'm landing this to ease testing and releasing. Please send the rest of the open tasks as a separate PR

@mcollina
fixup
19e872a 
Signed-off-by: Matteo Collina <[email protected]>
@mcollina mcollina merged commit a2cbd1d into main May 9, 2024
9 checks passed
@mcollina mcollina deleted the flakey5/frontend branch May 9, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@iamfortune iamfortune Awaiting requested review from iamfortune

@Fmusso94 Fmusso94 Awaiting requested review from Fmusso94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Simple “default” UI for querying the LLMs.
2 participants
@flakey5 @mcollina