Composer config should use prefix not path #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please reopen this PR to https://github.com/platformatic/platformatic/tree/main/docs |
mcollina
reviewed
Oct 4, 2024
| @@ -292,7 +292,7 @@ and the `path` in `web/composer/platformatic.json` accordingly. | |||
|
|
|||
| ## `fetch` the data from the Node.js app in the Next.js app | |||
|
|
|||
| Replace `web/next/src/app/page.js`, with the following code: | |||
| Replace `web/next/app/page.js`, with the following code: | |||
There was a problem hiding this comment.
This change is correct dependening on the choices picked when creating a Next app.
There was a problem hiding this comment.
Ah, I just went with the default selections and it was wrong for that.
|
Those changes have already been fixed but @ShogunPanda broke the rendering of the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The composer configs should use
prefixrather thanpath. Also, the path to the next page file seems to be incorrect. There's also an issue that the imported stylesheet seems to not exist...not sure where that's supposed to be coming from. 🤔