refactor: resolver logic #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-sanfratello
force-pushed
the
refactor/resolver-logic
branch
from
950c534 to
67308fc
Compare
mcollina
reviewed
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mean to refactor the resolver logic and and what it entails.
The idea behind is to plan the query to perform on subgraphs on the first stage, then perform them all, and keep the query tree structure to merge the results, while the current logic make the merging operation detached from the query plan, resulting complicated to implement.
To achieve that, a big refactor is needed, in logic and code design.
This logic now is deadly simple, but can be improved, for example executing parallel queries on the same subgrahs when possible, operating on a single function; there are also other parts that can be improved as well, in performance or logic.
To be retro-compatible, all the tests are been keep.
It also add logger in options.