fix: handle errors thrown in subgraph #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Sep 14, 2024
|
@mcollina My bad, thanks for the hint! Added the missing unit tests. |
mcollina
pushed a commit
that referenced
this pull request
Sep 19, 2024
* fix: handle errors thrown in subgraph * test: added tests for makeGraphqlRequest * test: remove validationRules from test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception was thrown in a graphql endpoint (not an exception in GraphQl but before, e.g. the context) the graphql composer was not able to handle this properly. It was just checking if
errorswas set in the response and if it was not present tried to access the subgraph response fromdatawhich was not returned in the case of an exception thrown before. This resulted in aCannot read properties of undefinederror. To avoid this we now check iferroris present in the response and throw an error in that case.