Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets isRuntimeContext to true before asking for fields #49

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Sets isRuntimeContext to true before asking for fields #49

merged 1 commit into from
Dec 1, 2023

Conversation

leorossi
Copy link
Contributor

@leorossi leorossi commented Dec 1, 2023 •
edited
Loading

Service should not expose fields if isRuntimeContext == true

Refs: platformatic/platformatic#1873

marcopiraccini
marcopiraccini approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@marcopiraccini marcopiraccini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcopiraccini marcopiraccini merged commit f898e63 into main Dec 1, 2023
1 check passed
@marcopiraccini marcopiraccini deleted the set-runtime-context-before-getting-fields branch December 3, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcopiraccini marcopiraccini marcopiraccini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leorossi @marcopiraccini