Windows release sign #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcopiraccini
changed the title
marcopiraccini
force-pushed
the
release-win-sign
branch
from
cc33306 to
23c0451
Compare
mcollina
reviewed
Dec 3, 2023
.github/workflows/release.yml
Outdated
| echo "::set-output name=KEYPAIR_NAME::gt-standard-keypair" | ||
| echo "::set-output name=CERTIFICATE_NAME::gt-certificate" | ||
| echo "SM_HOST=${{ secrets.SM_HOST }}" >> "$GITHUB_ENV" | ||
| echo "SM_API_KEY=${{ secrets.SM_API_KEY }}" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
how are those secrets configured? They should be configured as an environment in GH.
There was a problem hiding this comment.
There was a problem hiding this comment.
But you are right, they should be configured as GH env. Doing the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This signs the exe windows installer