Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add command runner #65

Merged
merged 4 commits into from
Dec 5, 2023
Merged

feat: add command runner #65

merged 4 commits into from
Dec 5, 2023

Conversation

ivan-tymoshenko
Copy link
Member

No description provided.

@ivan-tymoshenko ivan-tymoshenko marked this pull request as ready for review December 5, 2023 12:50
marcopiraccini
marcopiraccini approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@marcopiraccini marcopiraccini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and it works (tested on win and linux) but please fix the tests asserts

@marcopiraccini marcopiraccini merged commit b5792dc into main Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcopiraccini marcopiraccini marcopiraccini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-tymoshenko @marcopiraccini