Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: import always a fresh generator #660

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

marcopiraccini
Copy link
Contributor

@marcopiraccini marcopiraccini commented May 9, 2024

Fixes: #658
Includes also some dep updates

@marcopiraccini marcopiraccini marked this pull request as ready for review May 10, 2024 12:26
Signed-off-by: marcopiraccini <[email protected]>
Signed-off-by: marcopiraccini <[email protected]>
@marcopiraccini marcopiraccini force-pushed the import-fresh-generators branch from eabc6c8 to e346ce1 Compare May 10, 2024 12:30
@marcopiraccini marcopiraccini changed the title Import always a fresh generator Fix: import always a fresh generator May 10, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a996fff into main May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

once loaded, a generator is kept forever in memory
3 participants