Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/adding-info-in-case-import-works #71

Merged

Conversation

tonysnowboardunderthebridge
Copy link
Contributor

@tonysnowboardunderthebridge tonysnowboardunderthebridge commented Dec 7, 2023

Hi @mcollina

thanks to @marcopiraccini 🍻 we found that

  • if a user select a folder that is inside a folder tree where he already had a node_modules installed, the folder that he selected is not prepared and he can continue the installation of the app
  • same stuff if you have platformatic installed globally.

this is what the user will see

image

Signed-off-by: Antonio Sonis <[email protected]>
@marcopiraccini
Copy link
Contributor

marcopiraccini commented Dec 7, 2023

The cannot read properties of null is do to the fact that the user has already @platformatic/service somewhere and npm finds it, but it's a version with no Generator

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tonysnowboardunderthebridge tonysnowboardunderthebridge merged commit d102119 into main Dec 7, 2023
1 check passed
@tonysnowboardunderthebridge tonysnowboardunderthebridge deleted the feature/adding-info-in-case-import-works branch December 21, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants