Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency electron-updater to v6.3.0 [security] #864

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 25, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
electron-updater (source) 6.2.1 -> 6.3.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-39698

Observations

The file packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts implements the signature validation routine for Electron applications on Windows. It executes the following command in a new shell (process.env.ComSpec on Windows, usually C:\Windows\System32\cmd.exe):

https://github.com/electron-userland/electron-builder/blob/140e2f0eb0df79c2a46e35024e96d0563355fc89/packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts#L35-L41

Because of the surrounding shell, a first pass by cmd.exe expands any environment variable found in command-line above.

Exploitation

This creates a situation where verifySignature() can be tricked into validating the certificate of a different file than the one that was just downloaded. If the step is successful, the malicious update will be executed even if its signature is invalid.

Impact

This attack assumes a compromised update manifest (server compromise, Man-in-the-Middle attack if fetched over HTTP, Cross-Site Scripting to point the application to a malicious updater server, etc.).

Patch

This vulnerability was patched in #​8295, by comparing the path in the output of Get-AuthenticodeSignature with the intended one. The patch is available starting from 6.3.0-alpha.6.


Release Notes

electron-userland/electron-builder (electron-updater)

v6.3.0

Compare Source

Minor Changes
Patch Changes

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title fix(deps): update dependency electron-updater to v6.3.0 [security] fix(deps): update dependency electron-updater to v6.3.0 [security] - autoclosed Sep 25, 2024
@renovate renovate bot closed this Sep 25, 2024
@renovate renovate bot deleted the renovate/npm-electron-updater-vulnerability branch September 25, 2024 16:30
@renovate renovate bot changed the title fix(deps): update dependency electron-updater to v6.3.0 [security] - autoclosed fix(deps): update dependency electron-updater to v6.3.0 [security] Sep 26, 2024
@renovate renovate bot reopened this Sep 26, 2024
@renovate renovate bot restored the renovate/npm-electron-updater-vulnerability branch September 26, 2024 23:05
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch from 0b15478 to 88b3a82 Compare September 26, 2024 23:05
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch from 88b3a82 to aff9192 Compare September 30, 2024 14:54
@marcopiraccini marcopiraccini merged commit da5f04b into main Sep 30, 2024
2 checks passed
@renovate renovate bot deleted the renovate/npm-electron-updater-vulnerability branch September 30, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant