Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use builtin fetch for Node if exists #2

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Use builtin fetch for Node if exists #2

merged 1 commit into from
Apr 22, 2024

Conversation

flakey5
Copy link
Contributor

@flakey5 flakey5 commented Apr 14, 2024 •
edited
Loading

@flakey5 flakey5 mentioned this pull request Apr 16, 2024
Closed
mcollina
mcollina requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do a better fix. Rip node-fetch and just use fetch.

mcollina
mcollina approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5047fd2 into platformatic:main Apr 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flakey5 @mcollina