Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple naive hooks implementation #25

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Simple naive hooks implementation #25

merged 5 commits into from
Nov 7, 2024

Conversation

marcopiraccini
Copy link
Contributor

No description provided.

@marcopiraccini marcopiraccini marked this pull request as ready for review November 5, 2024 09:03
Copy link
Collaborator

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice!

Signed-off-by: marcopiraccini <[email protected]>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add this to the Readme?

Signed-off-by: marcopiraccini <[email protected]>
@marcopiraccini
Copy link
Contributor Author

@mcollina @ShogunPanda PTAL

Copy link
Collaborator

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcopiraccini marcopiraccini changed the title Simple hooks implementation for request, response, errors Simple naive hooks implementation Nov 6, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e51eacb into main Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants