Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve consistency between Blues boards #824

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Dec 18, 2024

Builds on work provided by @maxgerhardt, to improve the consistency across Blues boards.

@zfields
Copy link
Contributor Author

zfields commented Dec 18, 2024

I do have one question.

Is the following:

    "framework_extra_flags": {
      "arduino": "-DCUSTOM_PERIPHERAL_PINS -DPIO_FRAMEWORK_ARDUINO_ENABLE_CDC"
    },

used to provide a default, or will that make it ALWAYS true?

I am specifically interested in -DPIO_FRAMEWORK_ARDUINO_ENABLE_CDC. If it cannot be disabled, then I went the wrong direction, and I would need to remove it from Cygnet as well.

@valeros
Copy link
Member

valeros commented Dec 23, 2024

I am specifically interested in -DPIO_FRAMEWORK_ARDUINO_ENABLE_CDC. If it cannot be disabled, then I went the wrong direction, and I would need to remove it from Cygnet as well.

This flag will be always added, unless it's disabled via the build_unflags option.

Please also move -DARDUINO_CYGNET and -DARDUINO_SWAN_R5 to framework_extra_flags field.

@zfields
Copy link
Contributor Author

zfields commented Jan 13, 2025

@valeros I have made the changes you requested, and we are ready to merge.

@valeros valeros merged commit 0de87ed into platformio:develop Jan 14, 2025
@valeros
Copy link
Member

valeros commented Jan 14, 2025

Thanks, merged.

@zfields zfields deleted the blues branch January 14, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants