-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to use custom mbed-os version in platformio #214
base: develop
Are you sure you want to change the base?
Conversation
frameworks/mbed_extra.rst
Outdated
Custom version of Mbed | ||
^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
PlatformIO comes with only a few versions of Mbed supported out of the box. If you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change this wording to something like "PlatformIO only has certain versions of mbed-os in the official package package registry, as queryable through the API", just to give people a pointer as to where to find natively supported versions.
The general problem with telling people how to use custom versions is that they then think
This is definitely useful information for many people, but having it in official docs would give a false sense of "this always works, just do that". |
frameworks/mbed_extra.rst
Outdated
} | ||
EOF | ||
|
||
Then one ca use the following `platformio.ini` file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slight typo in ca
-> can
here
platform = ststm32 | ||
framework = mbed | ||
platform_packages = | ||
framework-mbed @ file://framework-mbed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- configuration is missing
board = ...
line to make it complete, does not mention to add it - Maybe general link to https://docs.platformio.org/en/latest/projectconf/section_env_platform.html#platform-packages would be good
Thanks a lot @maxgerhardt I'll try to address your comments ASAP. |
I agree and propose to include a big disclamer in this section. |
4fb2179
to
0376a40
Compare
I've updated a bit the PR, hopefully addressing all your comments. Thanks again. |
Bump...merge this? |
No description provided.