Compatibility for better simulator reloads #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem where multiple requests would be made for a dynamically loaded file. It also allows for squashing of equivalent sources with different http paths (eg. "http://mysite.com/modules/x.js" and "modules/x.js")
| @@ -370,6 +363,17 @@ | |||
| this.eval = function(code, path) {}; | |||
| this.fetch = function(path) { return contentsOfPath; }; | |||
| this.log = function(args...) {}; | |||
|
|
|||
| this.getNamespace = function(key) { return CONFIG.shortName + ':' + key }; | |||
There was a problem hiding this comment.
maybe getNamespace should live outside of jsio since it seems to be devkit-specific
There was a problem hiding this comment.
Is there no way to identify a running jsio app? Seems like there must be (I thought CONFIG was from jsio not devkit)
Conflicts: packages/preprocessors/compiler.js
| @@ -677,7 +923,7 @@ | |||
| return possibilities[i]; | |||
| } | |||
|
|
|||
| if (path in failedFetch) { possibilities.splice(i--, 1); } | |||
| if (ENV.hasFetchFailed(path)) { possibilities.splice(i--, 1); } | |||
There was a problem hiding this comment.
why are these functions moving into ENV?
|
I don't understand the concept of namespaces. Maybe it's the function calling convention: What's a namespace and how might it be used? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See play-co/devkit#238