Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some handy features (non-UTF8 charset decoding, webirc header support) #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thulinma
Copy link

@Thulinma Thulinma commented Sep 4, 2011

I've been using orbited2 for a while now on my own server to run a WebIRC script that connects to my IRC server.
However, this has a few problems:

1 - Some IRC clients do not produce valid UTF-8, crashing any user connected through orbited2.
2 - All users that connect though orbited2 show up as IP address "localhost", effectively making it impossible to ban them.

Problem 1 is fixed by the non-UTF8 charset decoding, turning all incoming data into valid UTF-8.
(Note: The non-UTF8 charset decoding was not added by me, but by a friend of mine: Pol Van Aubel ([email protected]) )

Problem 2 is fixed by the addition of a webirc setting in the config file, allowing people to set a password for the webirc "standard" that deals with solving exactly this problem.

Since my server is IPv6 enabled and apparently webirc has problems with non-IPv4 addresses, I made the webirc command only take the IPv4 part of the IPv6 address if available. This is obviously wrong in the case that the server is not IPv6 enabled, and even more wrong when somebody actually connects over IPv6. To combat this, I also added a "ipv6entry" command, which always takes the valid client address, but assumes the server reading this information understands both IPv4 and IPv6 (see this as the "future proof" version of this command).

I hope you find these additions useful and will add them to the main project!
Speaking of - is this still in active development? Just wondering :-)

@bivald
Copy link

bivald commented Nov 28, 2011

I think problem #2 has been discussed before and rejected since it was to narrow (even though I would like it as well). However, problem #1 is a real issue (and has been since orbited 0.7) and it would be awesome if it would be fixed.

@Thulinma
Copy link
Author

Perhaps just the ipv6entry config then - which simply copies the line you input in the setting, with the IP filled in. This is a very generic usage not restricted to just IRC... I've already used this to sent through the original IP address to several other server systems using this. It's been very helpful :-)

@bivald
Copy link

bivald commented Nov 29, 2011

I'm all for it

…nd support for webirc headers and a IPv6 equivalent thereof.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants