Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: analysis warning #117

Merged
merged 3 commits into from
Feb 23, 2025
Merged

Conversation

akaboshinit
Copy link
Contributor

@akaboshinit akaboshinit commented Jan 9, 2025

This pull request includes various improvements and refactorings across multiple files in the project. The changes focus on adding const constructors, using ColoredBox instead of Container, and ensuring consistent import ordering.

Improvements and Refactoring:

  • Const Constructors and Widgets:

    • Added const constructors and const widgets in examples/generator_app/lib/bar/bar.dart, examples/generator_app/lib/bar/bar.story.dart, examples/generator_app/lib/foo/foo_widget.story.dart, examples/generator_app/lib/image/asset_image.story.dart, examples/generator_app/lib/page/page.story.dart, and examples/generator_app/test/snapshot_test.dart. [1] [2] [3] [4] [5] [6] [7] [8]
  • ColoredBox Usage:

    • Replaced Container with ColoredBox in examples/generator_app/lib/bar/bar.dart and examples/simple_app/lib/bar/bar.dart to improve performance when only a color is needed.
  • Import Ordering and Cleanup:

    • Organized and cleaned up imports in examples/generator_app/lib/bar/bar.story.dart, examples/simple_app/lib/page/page.story.dart, and examples/simple_app/lib/scrollable/scrollable.story.dart. [1] [2] [3]
  • Ignoring Linter Rules:

    • Added // ignore_for_file: camel_case_types comment in examples/generator_app/lib/foo/foo_widget.story.dart and examples/simple_app/lib/foo/foo_widget.story.dart. [1] [2]
  • Analysis Options:

    • Updated analysis_options.yaml to exclude generated_playbook.dart from analysis.

@KyoheiG3
Copy link
Member

thx

@KyoheiG3 KyoheiG3 merged commit 425e17e into playbook-ui:main Feb 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants