fix(build): duplicate nav menu on tutorial pages #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue introduced in #522 The ordering of the plugins requires localization to run before tutorials.
willeastcott
approved these changes
Sep 28, 2023
|
This is great. Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue introduced in #522
The ordering of the plugins requires localization to run before tutorials. Without it, both the english and localised nav menus are displayed in demo pages.
Aside from an updated billing email, this now produces an identical set of build files compared to those generated prior to updating plugins. Confirmed with WinMerge.
Fixes duplicate nav menu on tutorial pages.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.