Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest API limits documentation is updated #526

Merged
merged 10 commits into from
Oct 12, 2023
Merged

rest API limits documentation is updated #526

merged 10 commits into from
Oct 12, 2023

Conversation

isumygin-sc
Copy link
Contributor

Fixes #

rest API rate limiting doc is updated

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@isumygin-sc isumygin-sc requested a review from a team October 12, 2023 13:30
@isumygin-sc isumygin-sc self-assigned this Oct 12, 2023
Comment on lines 129 to 131
* **normal:** The normal rate limit allows 120-240 requests per minute.
* **strict:** The strict rate limit allows 5-10 requests per minute.
* **assets:** The assets rate limit allows 60-120 requests per minute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to provide an explanation here for why there's a range instead of a specific number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to provide an explanation here for why there's a range instead of a specific number?

updated as a table

Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some minor feedback. Also, just wanted to log a reminder that we need to figure out how to get English changes into other languages still. 😄

@isumygin-sc
Copy link
Contributor Author

Approving with some minor feedback. Also, just wanted to log a reminder that we need to figure out how to get English changes into other languages still. 😄

added translation for Russian documentation

@isumygin-sc isumygin-sc merged commit b366c19 into dev Oct 12, 2023
3 of 5 checks passed
@isumygin-sc isumygin-sc deleted the rest-api-limits branch October 12, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants