Fixes for gsplat spherical harmonics (#7182)

playcanvas · Dec 9, 2024 · 29a8a0c · 29a8a0c
1 parent c017a1f
commit 29a8a0c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/scene/gsplat/gsplat-compressed.js b/src/scene/gsplat/gsplat-compressed.js
@@ -109,10 +109,10 @@ class GSplatCompressed {
             const srcCoeffs = [3, 8, 15][shBands - 1];
 
             for (let i = 0; i < numSplats; ++i) {
-                for (let j = 0; j < srcCoeffs; ++j) {
-                    target0[i * 16 + j] = shData[(i * 3 + 0) * srcCoeffs + j];
-                    target1[i * 16 + j] = shData[(i * 3 + 1) * srcCoeffs + j];
-                    target2[i * 16 + j] = shData[(i * 3 + 2) * srcCoeffs + j];
+                for (let j = 0; j < 15; ++j) {
+                    target0[i * 16 + j] = j < srcCoeffs ? shData[(i * 3 + 0) * srcCoeffs + j] : 127;
+                    target1[i * 16 + j] = j < srcCoeffs ? shData[(i * 3 + 1) * srcCoeffs + j] : 127;
+                    target2[i * 16 + j] = j < srcCoeffs ? shData[(i * 3 + 2) * srcCoeffs + j] : 127;
                 }
             }
 

diff --git a/src/scene/shader-lib/chunks/gsplat/vert/gsplat.js b/src/scene/shader-lib/chunks/gsplat/vert/gsplat.js
@@ -32,7 +32,7 @@ void main(void) {
 
     // evaluate spherical harmonics
     #if SH_BANDS > 0
-        clr.xyz += evalSH(state, projState));
+        clr.xyz += evalSH(state, projState);
     #endif
 
     applyClipping(projState, clr.w);