remove uncecessary off's

playcanvas · Dec 3, 2024 · 5822a7f · 5822a7f
1 parent 8ea7a1b
commit 5822a7f
Show file tree

Hide file tree

Showing 8 changed files with 0 additions and 29 deletions.
diff --git a/src/framework/components/element/component.js b/src/framework/components/element/component.js
@@ -2560,14 +2560,10 @@ class ElementComponent extends Component {
             this.system.app.elementInput.addElement(this);
         }
 
-        this._evtLayersChanged?.off();
         this._evtLayersChanged = scene.on('set:layers', this.onLayersChanged, this);
 
         if (layers) {
-            this._evtLayerAdded?.off();
             this._evtLayerAdded = layers.on('add', this.onLayerAdded, this);
-
-            this._evtLayerRemoved?.off();
             this._evtLayerRemoved = layers.on('remove', this.onLayerRemoved, this);
         }
 

diff --git a/src/framework/components/element/image-element.js b/src/framework/components/element/image-element.js
@@ -797,7 +797,6 @@ class ImageElement {
 
     // Hook up event handlers on sprite asset
     _bindSprite(sprite) {
-        this._evtSetMeshes?.off();
         this._evtSetMeshes = sprite.on('set:meshes', this._onSpriteMeshesChange, this);
         sprite.on('set:pixelsPerUnit', this._onSpritePpuChange, this);
         sprite.on('set:atlas', this._onAtlasTextureChange, this);

diff --git a/src/framework/components/gsplat/component.js b/src/framework/components/gsplat/component.js
@@ -337,14 +337,10 @@ class GSplatComponent extends Component {
         const scene = this.system.app.scene;
         const layers = scene.layers;
 
-        this._evtLayersChanged?.off();
         this._evtLayersChanged = scene.on('set:layers', this.onLayersChanged, this);
 
         if (layers) {
-            this._evtLayerAdded?.off();
             this._evtLayerAdded = layers.on('add', this.onLayerAdded, this);
-
-            this._evtLayerRemoved?.off();
             this._evtLayerRemoved = layers.on('remove', this.onLayerRemoved, this);
         }
 

diff --git a/src/framework/components/light/component.js b/src/framework/components/light/component.js
@@ -1247,14 +1247,10 @@ class LightComponent extends Component {
 
         this.light.enabled = true;
 
-        this._evtLayersChanged?.off();
         this._evtLayersChanged = scene.on('set:layers', this.onLayersChanged, this);
 
         if (layers) {
-            this._evtLayerAdded?.off();
             this._evtLayerAdded = layers.on('add', this.onLayerAdded, this);
-
-            this._evtLayerRemoved?.off();
             this._evtLayerRemoved = layers.on('remove', this.onLayerRemoved, this);
         }
 

diff --git a/src/framework/components/model/component.js b/src/framework/components/model/component.js
@@ -953,14 +953,10 @@ class ModelComponent extends Component {
         const scene = app.scene;
         const layers = scene?.layers;
 
-        this._evtLayersChanged?.off();
         this._evtLayersChanged = scene.on('set:layers', this.onLayersChanged, this);
 
         if (layers) {
-            this._evtLayerAdded?.off();
             this._evtLayerAdded = layers.on('add', this.onLayerAdded, this);
-
-            this._evtLayerRemoved?.off();
             this._evtLayerRemoved = layers.on('remove', this.onLayerRemoved, this);
         }
 

diff --git a/src/framework/components/particle-system/component.js b/src/framework/components/particle-system/component.js
@@ -1974,14 +1974,10 @@ class ParticleSystemComponent extends Component {
             this.addMeshInstanceToLayers();
         }
 
-        this._evtLayersChanged?.off();
         this._evtLayersChanged = scene.on('set:layers', this.onLayersChanged, this);
 
         if (layers) {
-            this._evtLayerAdded?.off();
             this._evtLayerAdded = layers.on('add', this.onLayerAdded, this);
-
-            this._evtLayerRemoved?.off();
             this._evtLayerRemoved = layers.on('remove', this.onLayerRemoved, this);
         }
 

diff --git a/src/framework/components/render/component.js b/src/framework/components/render/component.js
@@ -818,14 +818,10 @@ class RenderComponent extends Component {
 
         this._cloneSkinInstances();
 
-        this._evtLayersChanged?.off();
         this._evtLayersChanged = scene.on('set:layers', this.onLayersChanged, this);
 
         if (layers) {
-            this._evtLayerAdded?.off();
             this._evtLayerAdded = layers.on('add', this.onLayerAdded, this);
-
-            this._evtLayerRemoved?.off();
             this._evtLayerRemoved = layers.on('remove', this.onLayerRemoved, this);
         }
 

diff --git a/src/framework/components/sprite/component.js b/src/framework/components/sprite/component.js
@@ -677,14 +677,10 @@ class SpriteComponent extends Component {
         const scene = app.scene;
         const layers = scene.layers;
 
-        this._evtLayersChanged?.off();
         this._evtLayersChanged = scene.on('set:layers', this._onLayersChanged, this);
 
         if (layers) {
-            this._evtLayerAdded?.off();
             this._evtLayerAdded = layers.on('add', this._onLayerAdded, this);
-
-            this._evtLayerRemoved?.off();
             this._evtLayerRemoved = layers.on('remove', this._onLayerRemoved, this);
         }