Clamp GS SH coefficients correctly (#7193)

playcanvas · Dec 13, 2024 · 9af3f9e · 9af3f9e
1 parent b1b9a81
commit 9af3f9e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/scene/gsplat/gsplat.js b/src/scene/gsplat/gsplat.js
@@ -323,9 +323,9 @@ class GSplat {
 
             // normalize
             for (let j = 0; j < 15; ++j) {
-                c[j * 3 + 0] = Math.floor((c[j * 3 + 0] / max * 0.5 + 0.5) * t11 + 0.5);
-                c[j * 3 + 1] = Math.floor((c[j * 3 + 1] / max * 0.5 + 0.5) * t10 + 0.5);
-                c[j * 3 + 2] = Math.floor((c[j * 3 + 2] / max * 0.5 + 0.5) * t11 + 0.5);
+                c[j * 3 + 0] = Math.max(0, Math.min(t11, Math.floor((c[j * 3 + 0] / max * 0.5 + 0.5) * t11 + 0.5)));
+                c[j * 3 + 1] = Math.max(0, Math.min(t10, Math.floor((c[j * 3 + 1] / max * 0.5 + 0.5) * t10 + 0.5)));
+                c[j * 3 + 2] = Math.max(0, Math.min(t11, Math.floor((c[j * 3 + 2] / max * 0.5 + 0.5) * t11 + 0.5)));
             }
 
             // pack