Replaces Terser/Babel. Improves Build Time #6920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any change to sizes? |
|
Also is there a difference in ECMA compliance, if there is a difference between ES5 versio s, and what it results in? |
|
It has the same targets for both UMD and ES builds, so should match current
outputs.
I need to adjust some settings to get the build size back in line though,
so consider this draft for now.
…On Fri, 6 Sep 2024 at 18:15, mrmaxm ***@***.***> wrote:
Also is there a difference in ECMA compliance, if there is a difference
between ES5 versio s, and what it results in?
—
Reply to this email directly, view it on GitHub
<#6920 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJFLFPULMRTOP2IBLJDHTZVHPLDAVCNFSM6AAAAABNY3P7G2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUGQ4TGNBTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
If it is not possible to bring the build size to what terser is capable of, then we can consider to use this for a debug build, as it is usually the one that takes the most of the time during development and its size is of less importance. |
|
Below are the file sizes. Will continue investigating
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Babel + Terser with SWC which improves the build time of each target.
The same ES5 targets are used for UMD build outputs.
With Terser/Babel ~ 1m40s
With SWC ~ 51s
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.