Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bloom render pass optimization #7104

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Nov 12, 2024

The bloom uses a series of downscaling and upscaling render passes to blur.
Instead of executing more costly 13-samples downscaling at all time, use just a single sample box filter for downscaling from full to half res, which is the most costly pass. No visible difference to the quality.

Cost of 4k rendering of Post-Processing example on apple m1 max:
before: 4.4ms
now: 4.2ms

@mvaligursky mvaligursky self-assigned this Nov 12, 2024
@mvaligursky mvaligursky added performance Relating to load times or frame rate area: graphics Graphics related issue labels Nov 12, 2024
@mvaligursky mvaligursky requested a review from a team November 12, 2024 12:49
@mvaligursky mvaligursky merged commit 1939666 into main Nov 13, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mb-bloom-pass-performance branch November 13, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue performance Relating to load times or frame rate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants