Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for Scene#skybox and Scene#envAtlas #7118

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Fix types for Scene#skybox and Scene#envAtlas #7118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/scene/scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ class Scene extends EventHandler {
/**
* Sets the environment lighting atlas.
*
* @type {Texture}
* @type {Texture|null}
*/
set envAtlas(value) {
if (value !== this._envAtlas) {
Expand Down Expand Up @@ -391,7 +391,7 @@ class Scene extends EventHandler {
/**
* Gets the environment lighting atlas.
*
* @type {Texture}
* @type {Texture|null}
*/
get envAtlas() {
return this._envAtlas;
Expand Down Expand Up @@ -529,7 +529,7 @@ class Scene extends EventHandler {
/**
* Sets the base cubemap texture used as the scene's skybox when skyboxMip is 0. Defaults to null.
*
* @type {Texture}
* @type {Texture|null}
*/
set skybox(value) {
if (value !== this._skyboxCubeMap) {
Expand All @@ -541,7 +541,7 @@ class Scene extends EventHandler {
/**
* Gets the base cubemap texture used as the scene's skybox when skyboxMip is 0.
*
* @type {Texture}
* @type {Texture|null}
*/
get skybox() {
return this._skyboxCubeMap;
Expand Down